GEOS icon indicating copy to clipboard operation
GEOS copied to clipboard

feat: enable THM coupling with plastic models

Open jhuang2601 opened this issue 1 year ago • 2 comments

This PR

  • [x] fix function interface to enable PorousDruckerPrager and PorousExtendedDruckerPrager and PorousModifiedCamClay for thermal coupling
  • [x] add smoke tests for these poro-thermo-plastic models to the integratedTests

jhuang2601 avatar Oct 25 '24 16:10 jhuang2601

Is everything in our formulation for THM valid for plastic models? I can't think of anything that would be an issue but it's good to think about it.

CusiniM avatar Oct 25 '24 20:10 CusiniM

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.56%. Comparing base (feb8f6c) to head (1896834). Report is 67 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3413   +/-   ##
========================================
  Coverage    57.56%   57.56%           
========================================
  Files         1092     1092           
  Lines        97837    97837           
========================================
+ Hits         56318    56320    +2     
+ Misses       41519    41517    -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 25 '24 21:10 codecov[bot]

The xml files seem to share most of the blocks except the ones for the solid constitutive models. It might be profitable to create a base file for all the shared block.

sytuannguyen avatar Oct 28 '24 04:10 sytuannguyen

Expected failure for adding new tests and rebaseline is needed

=======================
Test failures
=======================
ThermoPoroDruckerPrager_consolidation_smoke_01
ThermoPoroDruckerPrager_consolidation_smoke_02
ThermoPoroExtendedDruckerPrager_consolidation_smoke_01
ThermoPoroExtendedDruckerPrager_consolidation_smoke_02
ThermoPoroMCC_consolidation_smoke_01
ThermoPoroMCC_consolidation_smoke_02

jhuang2601 avatar Oct 28 '24 21:10 jhuang2601

@CusiniM @rrsettgast @cssherman Could you please review this PR?

jhuang2601 avatar Oct 29 '24 14:10 jhuang2601