GEOS icon indicating copy to clipboard operation
GEOS copied to clipboard

feat: Add immiscible multiphase flow package

Open CusiniM opened this issue 1 year ago • 1 comments

CusiniM avatar Jul 30 '24 00:07 CusiniM

Codecov Report

Attention: Patch coverage is 78.34674% with 296 lines in your changes missing coverage. Please review.

Project coverage is 57.11%. Comparing base (93f0252) to head (84613c5). Report is 87 commits behind head on develop.

Files with missing lines Patch % Lines
...sicsSolvers/fluidFlow/ImmiscibleMultiphaseFlow.cpp 60.37% 233 Missing :warning:
...miscibleMultiphase/ImmiscibleMultiphaseKernels.hpp 90.85% 32 Missing :warning:
...es/hypre/mgrStrategies/ImmiscibleMultiphaseFVM.hpp 0.00% 15 Missing :warning:
...sicsSolvers/fluidFlow/ImmiscibleMultiphaseFlow.hpp 52.38% 10 Missing :warning:
...onents/linearAlgebra/interfaces/hypre/HypreMGR.cpp 0.00% 3 Missing :warning:
...els/immiscibleMultiphase/KernelLaunchSelectors.hpp 66.66% 2 Missing :warning:
...ts/fluidFlowTests/testImmiscibleMultiphaseFlow.cpp 99.01% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3251      +/-   ##
===========================================
+ Coverage    56.82%   57.11%   +0.29%     
===========================================
  Files         1154     1165      +11     
  Lines        99984   101351    +1367     
===========================================
+ Hits         56816    57888    +1072     
- Misses       43168    43463     +295     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Sep 18 '24 00:09 codecov[bot]

Overall looks pretty good, just some minor things here and there, cleanup and remove commented code

paveltomin avatar Nov 19 '24 23:11 paveltomin

I'd remove the file host-configs/Stanford/ubuntu22.cmake before merging this branch into the develop branch.

matteofrigo5 avatar Dec 12 '24 03:12 matteofrigo5