GEOS icon indicating copy to clipboard operation
GEOS copied to clipboard

Adding pressure stabilization for single phase poromechanics

Open ryar9534 opened this issue 1 year ago • 1 comments

Implemented stabilized flux kernels to enable pressure jump stabilization for single-phase poromechanics. Also moves some stabilization-related functions from MultiphasePoromechanics to PoromechanicsSolver, as now that single-phase stabilization exists it could be unified.

Also adding input files to perform integrated tests with more physical meaning directly related to pressure stability.

ryar9534 avatar Apr 28 '24 21:04 ryar9534

Codecov Report

Attention: Patch coverage is 1.40845% with 140 lines in your changes missing coverage. Please review.

Project coverage is 56.40%. Comparing base (f856214) to head (a1b9ad9). Report is 103 commits behind head on develop.

Files with missing lines Patch % Lines
...vers/fluidFlow/StabilizedSinglePhaseFVMKernels.hpp 0.00% 58 Missing :warning:
...hysicsSolvers/multiphysics/PoromechanicsSolver.hpp 0.00% 48 Missing :warning:
...onents/physicsSolvers/fluidFlow/SinglePhaseFVM.cpp 0.00% 21 Missing :warning:
.../physicsSolvers/fluidFlow/SinglePhaseHybridFVM.cpp 0.00% 3 Missing :warning:
...sSolvers/multiphysics/SinglePhasePoromechanics.cpp 0.00% 3 Missing :warning:
...vers/multiphysics/SinglePhaseReservoirAndWells.hpp 0.00% 3 Missing :warning:
...ers/fluidFlow/CompositionalMultiphaseHybridFVM.cpp 0.00% 2 Missing :warning:
...nents/physicsSolvers/fluidFlow/SinglePhaseBase.cpp 66.66% 1 Missing :warning:
...csSolvers/multiphysics/MultiphasePoromechanics.cpp 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3100      +/-   ##
===========================================
- Coverage    56.45%   56.40%   -0.06%     
===========================================
  Files         1022     1023       +1     
  Lines        86431    86508      +77     
===========================================
- Hits         48794    48793       -1     
- Misses       37637    37715      +78     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 29 '24 05:04 codecov[bot]

Can we try to use in a case with a fault?

We can (it should work?), but I would like to know more about how tpfa is handled to make sure to get the element regions for stabilization right. I also still need to write the integrated tests for this PR.

ryar9534 avatar May 21 '24 19:05 ryar9534

Can we try to use in a case with a fault?

We can (it should work?), but I would like to know more about how tpfa is handled to make sure to get the element regions for stabilization right. I also still need to write the integrated tests for this PR.

if we want to add to the frac-matrix and frac-frac connections we probably can. The tpfa is basically the same as for the matrix just with some "special" transmissibilities. It's assembled by looping on the dedicated stencil types.

CusiniM avatar May 21 '24 22:05 CusiniM

@ryar9534 there are some conflicts now, please resolve

paveltomin avatar Jun 14 '24 13:06 paveltomin

@ryar9534 there are some conflicts now, please resolve

I think I have fixed this

ryar9534 avatar Jun 14 '24 16:06 ryar9534