GEOS icon indicating copy to clipboard operation
GEOS copied to clipboard

Enable high order for fwi in acoustic wave solver

Open acitrain opened this issue 1 year ago • 1 comments

This PR generalize the formula for gradient computation inside the acoustic second order wave solver to high orders

The main change is the computation of the number of nodes per elements instead of hardcoded it to 8

acitrain avatar Feb 23 '24 12:02 acitrain

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 53.16%. Comparing base (cb20b88) to head (06a595e). Report is 323 commits behind head on develop.

Files with missing lines Patch % Lines
...olvers/wavePropagation/AcousticWaveEquationSEM.cpp 0.00% 10 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2998      +/-   ##
===========================================
- Coverage    53.16%   53.16%   -0.01%     
===========================================
  Files          981      981              
  Lines        83492    83494       +2     
===========================================
  Hits         44386    44386              
- Misses       39106    39108       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Feb 23 '24 13:02 codecov[bot]

@sframba Is this deprecated or superseded?

rrsettgast avatar Dec 17 '24 18:12 rrsettgast

We can close it, in fact the formula was right at the beginning so no need to change it

acitrain avatar Dec 18 '24 10:12 acitrain