GEOS icon indicating copy to clipboard operation
GEOS copied to clipboard

PVT & TPL error message rewrite

Open MelReyCG opened this issue 2 years ago • 4 comments

Minor rewrite of error messages concerning:

  • when well surface conditions are out of PVT tables bound,
  • when the TPL folder has not been properly set.

MelReyCG avatar Jan 10 '24 16:01 MelReyCG

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 53.20%. Comparing base (45725d5) to head (8bc796f).

Files Patch % Lines
...tutive/fluid/multifluid/CO2Brine/CO2BrineFluid.cpp 0.00% 3 Missing :warning:
...e/fluid/multifluid/reactive/ReactiveBrineFluid.cpp 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2929      +/-   ##
===========================================
- Coverage    53.20%   53.20%   -0.01%     
===========================================
  Files          989      989              
  Lines        83456    83456              
===========================================
- Hits         44405    44403       -2     
- Misses       39051    39053       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 19 '24 12:01 codecov[bot]

@MelReyCG could you please resolve the conflict?

paveltomin avatar Apr 01 '24 22:04 paveltomin

@paveltomin done!

MelReyCG avatar Apr 05 '24 08:04 MelReyCG

@paveltomin done!

it still shows conflict down below image

paveltomin avatar Apr 05 '24 14:04 paveltomin

@paveltomin I think that GitHub was struggling to update my last commit because I don't see it anymore (but there was a "updating last commit..." in the commits page).

MelReyCG avatar Apr 08 '24 08:04 MelReyCG

@MelReyCG the build keeps failing, please address

paveltomin avatar Apr 09 '24 14:04 paveltomin

@paveltomin @MelReyCG I "fixed" the make error, but the "fix" is a reversion, so perhaps @MelReyCG had other intentions?

rrsettgast avatar Apr 09 '24 16:04 rrsettgast