GEOS
GEOS copied to clipboard
Simplification & consolidation of CellElementRegion definition
In order to simplify the cellBlocks referencing and thus simplify user workflows, this PR propose the following functionalities:
- Possibility to reference all
cellBlockfrom aregionAttributeat once, without listing all primitives:
<CellElementRegion
name="burdens"
cellBlockAttributeValues="{ 1, 4, 5 }"
materialList="{}" />
instead of:
<CellElementRegion
name="burdens"
cellBlocks="{ 1_tetrahedra, 1_pyramids, 1_hexahedra, ...
4_tetrahedra, 4_pyramids, 4_hexahedra, ...
5_tetrahedra, 5_pyramids, 5_hexahedra, ... }"
materialList="{}" />
- Possibility to reference all cellBlocks with
fnmatchpatterns:
<CellElementRegion
name="reservoir"
cellBlocksMatch="{ * }"
materialList="{}" />
<CellElementRegion
name="reservoir"
cellBlocksMatch="{ [1-4]_* }"
materialList="{}" />
- This PR also improved the
cellBlockerrors:
- Improved the error when a
cellBlockis referenced twice - Added an error when the
cellBlockAttributeValues,cellBlocks,cellBlocksMatchattributes are mixed (allowing only one way to selectcellblocks). - Improved the error when a referenced
cellBlockis missing, - Improved the error when failing to select
cellBlocks. See the form and more details here: new cellBlocks errors.pdf (not up to date).
This PR also:
- Updates the
Sphinxdocumentation page as it was incomplete, by providing the whole necessary python package list and a part to describe how to generate the.rstclass tables. - Adds some
.rsttables that were not previously pushed (forgotten?).
Codecov Report
Attention: Patch coverage is 85.80645% with 22 lines in your changes are missing coverage. Please review.
Project coverage is 53.51%. Comparing base (
8ec9d99) to head (1b63330). Report is 1 commits behind head on develop.
:exclamation: Current head 1b63330 differs from pull request most recent head 4a50918. Consider uploading reports for the commit 4a50918 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## develop #2878 +/- ##
===========================================
+ Coverage 53.26% 53.51% +0.24%
===========================================
Files 989 990 +1
Lines 83524 83652 +128
===========================================
+ Hits 44492 44769 +277
+ Misses 39032 38883 -149
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.