GEOS icon indicating copy to clipboard operation
GEOS copied to clipboard

Enabled PEBI in compositional hybrid FVM

Open francoishamon opened this issue 3 years ago • 1 comments

Following up on PR #2095, this PR enables the PEBI cells (prisms 5 to 11) in CompositionalMultiphaseHybridFVM. I tested the code with PoroElastic_hybridHexPrism_co2_3d.xml up to octagonal prisms (10 faces) and it seems to work well.

In passing, a kernel class is added in CompositionalMultiphaseHybridFVMKernels because the style of the hybrid FVM flux kernel was very outdated. After this PR, the hybrid FVM flux kernel will be in the same style as the other flux kernels. Even though the GitHub diff is very hard to read, there is no new assembly code in this PR, it has just been moved/reformated.

Ready for review, no numerical diffs, rebaseline necessary because PoroElastic_hybridHexPrism_co2_3d.xml now runs with hybrid FVM.

francoishamon avatar Jan 07 '23 00:01 francoishamon

Codecov Report

Attention: 182 lines in your changes are missing coverage. Please review.

Comparison is base (d306d3f) 51.44% compared to head (207dcda) 51.27%. Report is 3 commits behind head on develop.

Files Patch % Lines
...thermalCompositionalMultiphaseHybridFVMKernels.hpp 82.38% 93 Missing :warning:
...re/mgrStrategies/HybridMultiphasePoromechanics.hpp 0.00% 46 Missing :warning:
...ers/fluidFlow/CompositionalMultiphaseHybridFVM.cpp 40.54% 22 Missing :warning:
...hysicsSolvers/fluidFlow/HybridFVMHelperKernels.hpp 31.81% 15 Missing :warning:
...onents/linearAlgebra/interfaces/hypre/HypreMGR.cpp 0.00% 3 Missing :warning:
...csSolvers/multiphysics/MultiphasePoromechanics.cpp 0.00% 2 Missing :warning:
...sSolvers/fluidFlow/SinglePhaseHybridFVMKernels.hpp 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2236      +/-   ##
===========================================
- Coverage    51.44%   51.27%   -0.17%     
===========================================
  Files          972      972              
  Lines        87065    82381    -4684     
===========================================
- Hits         44788    42241    -2547     
+ Misses       42277    40140    -2137     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 08 '24 11:02 codecov[bot]