GEOS icon indicating copy to clipboard operation
GEOS copied to clipboard

Added Newton global damping by default in compositional solvers

Open francoishamon opened this issue 3 years ago • 0 comments

Jacques and I have some difficult cases in which the residual grows uncontrollably when the time step size is too large, which ends up crashing the simulation (line search does not fix the problem). To overcome the problem, this PR does two things:

  • [X] It turns on global damping on component density, pressure, and temperature by default (30% change allowed between iterations).
  • [X] It introduces a maxAllowedResidualNorm attribute in SolverBase set by default to 1e9. If the residual norm is above this value, the time step is cut to stop Newton divergence.

In passing, the PR unifies the solution scaling and solution check kernels in the flow/well solvers and adds some logging.

Ready for review, requires rebaseline

francoishamon avatar Aug 31 '22 07:08 francoishamon