extension_builder icon indicating copy to clipboard operation
extension_builder copied to clipboard
verified publisher icon FriendsOfTYPO3

[BUG] 🐛 Roundtrip merge not working

Open discoebbe opened this issue 1 year ago • 3 comments

Describe the bug When saving the extension custom methods inside existing models are deleted

To Reproduce

  1. Create a Model. Save it. Add custom methods.

  2. Configure overwriteSettings for Models like: overwriteSettings: Classes: Controller: merge Domain: Model: merge Repository: merge

  3. Open the Extension in Builder again and save it => all custom methods in the model class file are gone.

Expected behavior keep custom methods and only add setters and getters for new properties

TYPO3 Version 12.4.11

Extension Builder Version: 12.0.0-beta.1

discoebbe avatar Mar 15 '24 21:03 discoebbe

Same wrong behavior for Controllers and Repositories

discoebbe avatar Mar 15 '24 22:03 discoebbe

Thank you. I will have a look at it. If you know how to solve this, pull requests are welcome 😅

PKuhlmay avatar Mar 16 '24 07:03 PKuhlmay

It seems it broke at commit 733e71cf8a31d84fd3be67bb17410f003348cc94

PKuhlmay avatar Mar 27 '24 14:03 PKuhlmay