extension_builder icon indicating copy to clipboard operation
extension_builder copied to clipboard

[TASK] composer.json is only stored once

Open PKuhlmay opened this issue 2 years ago • 2 comments

The ext_emconf.php is prefilled with all the author data but not the composer.json

PKuhlmay avatar Dec 28 '23 15:12 PKuhlmay

The author data is indeed stored, but only at the first time. If there is already an existing composer.json file (because you already saved it) and then you add some authors, the authors will not be stored inside the composer.json because it is stored only once. See https://github.com/FriendsOfTYPO3/extension_builder/blob/1f0fb57cd325eb74df5ba7ba0b21db3649dcd4b3/Classes/Service/FileGenerator.php#L1062

PKuhlmay avatar Dec 28 '23 17:12 PKuhlmay

We could remove the line where it is checked, if the composer.json is already there. But it could lead into some other problems. Maybe it is safer, to only store it once, instead of overriding it again and again. Maybe the composer package name could be changed while overriding and then the extension is not installed any more.

PKuhlmay avatar Dec 28 '23 17:12 PKuhlmay