cakephp-upload icon indicating copy to clipboard operation
cakephp-upload copied to clipboard

Fix beforeMarshall if file uploads are array

Open albertcansado opened this issue 3 years ago • 5 comments

Fix error "Call to a member function getError() on array" when uploaded file is an array.

albertcansado avatar Sep 06 '22 09:09 albertcansado

Codecov Report

Merging #588 (f412266) into master (878cba2) will decrease coverage by 0.17%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #588      +/-   ##
============================================
- Coverage     95.68%   95.50%   -0.18%     
- Complexity      108      109       +1     
============================================
  Files            11       11              
  Lines           278      267      -11     
============================================
- Hits            266      255      -11     
  Misses           12       12              
Impacted Files Coverage Δ
src/Model/Behavior/UploadBehavior.php 94.56% <100.00%> (-0.18%) :arrow_down:
src/File/Writer/DefaultWriter.php 100.00% <0.00%> (ø)
src/File/Path/DefaultProcessor.php 100.00% <0.00%> (ø)
src/File/Path/Basepath/DefaultTrait.php 100.00% <0.00%> (ø)
src/File/Transformer/DefaultTransformer.php 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 06 '22 10:09 codecov[bot]

A few small bits to tidy up.

davidyell avatar Sep 06 '22 10:09 davidyell

Done!

albertcansado avatar Sep 08 '22 08:09 albertcansado

You have some build failures still to address, looking at the pipeline

davidyell avatar Sep 08 '22 08:09 davidyell

@albertcansado the code needs to have PHP 7.2 compat as it needs to keep CakePHP 4.x before 4.4 compatibility.

https://github.com/FriendsOfCake/cakephp-upload/blob/878cba2420e055d821eebeb50659141e3523e22d/composer.json#L19

@TerryKern's changes take care of that.

ravage84 avatar Oct 03 '22 14:10 ravage84