Duplicate configs on certain situations

[xavier83ar]

I was dealing with an issue that duplicates items when I passed nameCallback as an array like this [$object, 'methodName'], for example, with this config:

    // inside some Table::initialize()
    $this->addBehavior('Josegonzalez/Upload.Upload', [
        'imagen' => [
            'path' => 'webroot{DS}files{DS}mayoristas{DS}',
            'nameCallback' => [$this, 'buildName'],
        ],
    ]);

nameCallback is never called, to understand why, I read Behavior config after adding it, and nameCallback had this value

[
    0 => \MyObject\Instance,
    1 => "buildName",
    2 => \MyObject\Instance,
    3 => "buildName",
]

Digging into the code I find out that \Josegonzalez\Upload\Model\Behavior\UploadBehavior doesn't have a constructor, so it inherits from \Cake\ORM\Behavior, so the setConfig is called twice:

• https://github.com/cakephp/cakephp/blob/9711790699bd814a025e4b3345720265d005aa39/src/ORM/Behavior.php#L166
• https://github.com/FriendsOfCake/cakephp-upload/blob/1b76964166bd4c33c22a35c28a5a07098e3d08d4/src/Model/Behavior/UploadBehavior.php#L49

and in both cases is called with merge = true which is the default, I've tried replace that last line with $this->setConfig($configs, null, 'shallow'); and it works ok, but I don't know if that's the best solution as it is calling setConfig twice anyway, maybe a better solution is to add a constructor and call parent constructor with an empty array as configs.

[ADmad]

I had made a PR to overwrite the config instead of merging again but closed it to avoid any potential issue I might have not considered.

Your issue can be fixed by using 'nameCallback' => \Closure::fromCallable([$this, 'buildName']).

[ADmad]

In future the fields config should be nested inside a fields key so that it can be overwritten without worrying about affecting other configs. There's currently another issue too where className key needs to be explicitly unset due to having fields at top level of config array.