Extensions icon indicating copy to clipboard operation
Extensions copied to clipboard

Update README.md third-party extensions

Open Rambomst opened this issue 1 year ago • 9 comments

Added a third-party extension to the list for custom user stylesheets.

Rambomst avatar Nov 29 '24 00:11 Rambomst

Hello, Isn't it the same than the built-in core extension "User CSS"? https://github.com/FreshRSS/FreshRSS/tree/edge/lib/core-extensions/UserCSS

See also https://github.com/FreshRSS/Extensions/pull/256

Alkarex avatar Nov 29 '24 07:11 Alkarex

Hello, Isn't it the same than the built-in core extension "User CSS"? https://github.com/FreshRSS/FreshRSS/tree/edge/lib/core-extensions/UserCSS

See also https://github.com/FreshRSS/Extensions/pull/256

Similar but not the same.

Rambomst avatar Nov 29 '24 08:11 Rambomst

Similar but not the same.

Can you please briefly describe the differences?

Alkarex avatar Nov 29 '24 08:11 Alkarex

The default extension allows the user to define internal CSS via a textarea, it comes a hassle to edit when you get 1000+ lines.

I wanted to be able to have a stylesheet that was easily openable within an IDE that gives context highlighting etc.

The extension I added allows the user to define the location of an external stylesheet.

edit

Also the default extension behaves weirdly with CSS @imports, it will import them once, save it, and never run the @import again.

Rambomst avatar Nov 29 '24 08:11 Rambomst

The extension isn't set in stone of course. I think it would welcome the ability to provide a URL as well. :-)

Also the default extension behaves weirdly with CSS @imports, it will import them once, save it, and never run the @import again.

The extension doesn't do anything with @import. That's simply regular browser caching based on HTTP headers.

Frenzie avatar Nov 29 '24 09:11 Frenzie

The extension isn't set in stone of course. I think it would welcome the ability to provide a URL as well. :-)

If there is interest in this change then I am happy to open a PR to the core extension. Please let me know :)

Also the default extension behaves weirdly with CSS @imports, it will import them once, save it, and never run the @import again.

The extension doesn't do anything with @import. That's simply regular browser caching based on HTTP headers.

I performed a hard refresh, I thought that would have busted all the cache related things, no?

Rambomst avatar Nov 29 '24 09:11 Rambomst

I performed a hard refresh, I thought that would have busted all the cache related things, no?

My point is that the extension doesn't do any kind of processing. What goes in is what comes out with a Content-Type: text/css header, and a Last-Modified header indicating whenever you last clicked update. There isn't anything else to it.

Anything under @import is dealt with however @import is dealt with. My primary suspect in what you say is that this also means it doesn't add any CSP headers.

Frenzie avatar Nov 29 '24 10:11 Frenzie

I have opened a PR to FreshRSS which introduces this setting to the core UserCSS extension.

https://github.com/FreshRSS/FreshRSS/pull/7107

Rambomst avatar Dec 15 '24 22:12 Rambomst

Should be added to https://github.com/FreshRSS/Extensions/blob/master/repositories.json as well

Alkarex avatar Jan 12 '25 10:01 Alkarex