wordpress-sdk
wordpress-sdk copied to clipboard
Submit theme warning - replace esc_attr with esc_html
🐞 bug report
Behavior:
-
What is the issue? (*)When uploading themes to wordpress.org the following warning is triggered:

-
What is the expected behavior?The specified line of code in the SDK needsesc_attrreplacing withesc_html.
https://github.com/Freemius/wordpress-sdk/blob/master/templates/forms/subscription-cancellation.php#L136
Versions: (*)
-
Freemius SDK Version:2.3.2 -
WordPress Version:5.2 -
PHP Version:7.0
This is an easy fix as esc_attr and esc_html are almost identical: https://core.trac.wordpress.org/browser/trunk/src/wp-includes/formatting.php#L4449
I can take this one.
While testing with theme checker there is not error or warning. Now that I submitted in wp org it failed. Here is the error that I got.
