FreeTube icon indicating copy to clipboard operation
FreeTube copied to clipboard

[Bug]: Video Controls Too Low

Open deepspaceaxolotl opened this issue 1 year ago • 24 comments

Guidelines

  • [X] I have encountered this bug in the latest release of FreeTube.
  • [X] I have encountered this bug in the official downloads of FreeTube.
  • [X] I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • [X] I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • [X] This issue contains only one bug.

Describe the bug

As mentioned here in #5007, as it currently stands, on smaller screens (in my case, 1080p at 125% zoom, making it effectively act like an 864p screen), it is not possible to both have a wide enough window to have a full grid of four columns on playlist, channel and subscriptions pages, as well as a big video in theatre mode, and to see the video and playlist controls for a video without scrolling. The video control buttons are pushed down by both the likes count and the row the channel name is in, even if the former is turned off.

Expected Behavior

Having them immediately below the space for the title would be very helpful on smaller screens. As for the playlist controls, swapping them with the progress in a playlist would help in reaching them, and some of the padding could maybe be reduced if that isn't unwise.

Would appreciate help here!

Issue Labels

usability issue

FreeTube Version

v0.21.3 Beta

Operating System Version

Windows 10 version 22H2

Installation Method

.exe

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

No response

Nightly Build

deepspaceaxolotl avatar Aug 19 '24 10:08 deepspaceaxolotl

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Sep 17 '24 01:09 github-actions[bot]

I wonder if this could be configurable. Since FreeTube switched to the new video player, the bar of buttons at the bottom of the video has moved up somewhat and I find it a bit irritating. I would prefer no margin below the buttons but to still have them within the video player's frame. I imagine there are other people with other preferences.

Penguin-Guru avatar Nov 09 '24 05:11 Penguin-Guru

I think we might be talking about different buttons. I mean the ones under the actual video, the add to playlist and other ones, rather than the video controls within the frame of the video (play, subtitles, etc.).

deepspaceaxolotl avatar Nov 09 '24 09:11 deepspaceaxolotl

Ah, yes. I was thinking of the player buttons. I have some of the rows you mentioned disabled but I do still see the layout problem you described. That button bar looks level with the subscribe button, which is just below the channel name. I hadn't noticed this before but it would definitely make more sense for the buttons to be higher, perhaps level with the name of the video, since they are buttons related to the video rather than the channel.

Penguin-Guru avatar Nov 10 '24 06:11 Penguin-Guru

I wonder if this could be configurable. Since FreeTube switched to the new video player, the bar of buttons at the bottom of the video has moved up somewhat and I find it a bit irritating. I would prefer no margin below the buttons but to still have them within the video player's frame. I imagine there are other people with other preferences.

@Penguin-Guru I see what you mean now, might be worth opening an issue about this, I also find it slightly annoying.

deepspaceaxolotl avatar Nov 13 '24 12:11 deepspaceaxolotl

Apparently people have already opened issues about it. 👍

Penguin-Guru avatar Nov 16 '24 17:11 Penguin-Guru

@kommunarr any thoughts how this could be addressed?

You could try getting rid of the videoAreaMargin and swapping the videoMetrics row with the videoButtons row. I'm not sure I like it, though, and it may still not be enough to get 100% of the video height in frame depending on your device just because of how tall the video can be.

Screenshot_20241206_131002

kommunarr avatar Dec 06 '24 19:12 kommunarr

That's definitely better. If it would be possible to have the controls in the same row as the title unless the title is long enough to push them down like that, that'd be even better.

deepspaceaxolotl avatar Dec 06 '24 19:12 deepspaceaxolotl

I shared my thoughts on the issue I mistook this to be. Here's the link to that, in case it's useful: https://github.com/FreeTubeApp/FreeTube/issues/6165

Penguin-Guru avatar Dec 06 '24 20:12 Penguin-Guru

If someone wants to design and develop it, I'd be interested to see it. You'd also likely have to move some other things around to make the bottom right corner less vacant looking at that point. It's at most an 80 pixel difference, though, so it's a pretty modest benefit for most devices.

kommunarr avatar Dec 06 '24 20:12 kommunarr

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jan 14 '25 01:01 github-actions[bot]

This is a rather annoying issue. Has there been any updates on it?

russellmm avatar Feb 08 '25 21:02 russellmm

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Mar 09 '25 01:03 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Apr 08 '25 02:04 github-actions[bot]

Im interested in seeing how horrible this looks as im not experiencing this myself. Could you provide some screenshots of this?

Here's what it looks like for me with my laptop screen at 125% zoom and my monitor at 100%, in full screen, the narrowest I can get the window without making the video grid only three/two videos wide (with a comfortable window aspect ratio), and how tall I have to make it from there to comfortably see the controls.

125%: Image Image Image

100%: Image Image Image

(Side note, at 125% zoom, the video grid goes down to only two videos per row (only a couple rows visible on screen) very quickly when scaling down, it'd be nice to be able to see more than 4-6 videos on screen at once with a smaller screen.)

deepspaceaxolotl avatar Apr 26 '25 17:04 deepspaceaxolotl

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar May 25 '25 02:05 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jun 23 '25 02:06 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jul 22 '25 02:07 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Aug 20 '25 02:08 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Sep 18 '25 02:09 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Oct 17 '25 02:10 github-actions[bot]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Nov 15 '25 02:11 github-actions[bot]