Add more options to playback rate menu
Add more options to playback rate menu
Pull Request Type
- [ ] Bugfix
- [x] Feature Implementation
- [ ] Documentation
- [ ] Other
Related issue
closes #4564
Description
This pull request makes the playback rate menu smoother by providing users with more playback options at intervals of 0.05 from 0.25 to 3
Desktop
- OS: Ubuntu
- OS Version: 22.04
- FreeTube version: 0.20.0
Hi @msagr thank you for taking time to address this issue. Unfortunately you have interpreted the request incorrect.
OP meant that the default playback speed should be adjusted properly.
So when video playback rate interval is set to 0.1 the default playback speed should also be configurable in steps of 0.1 instead of being unchanged and showing steps of 0.25
https://github.com/FreeTubeApp/FreeTube/assets/73130443/ebfe4b20-4f8c-45fc-851c-4f38b75bb06a
Thanks a lot, I have tried to fix it in this PR. Please let me know if any other issue remains in this.
Thanks a lot, I have tried to fix it in this PR. Please let me know if any other issue remains in this.
I quickly checked what "videoPlaybackRateInterval" does, looks logical, did you test it? Seems cool
Oh, I mistakenly opened it in same PR. Should I make a separate commit removing the code i just committed or there is some other way of undoing it I am not aware of in my limited knowledge.
- Checkout the branch (people normally use a separate branch for a PR instead all into one branch but in this case
development - Create a branch to save the unrelated changes if you want to save them
- Reset branch
developmenthard to commitmake slider precise as per playback speed - Force push
Thanks @PikachuEXE for the tip, I will open a separate PR for other commit.
@absidue Seems updated
@efb4f5ff-1298-471a-8973-3d47447115dc type error resolved.
The playback rate seems broken when interval set to 0.1/0.5 (coz 0.25 is minimum value and now 1.0 cannot be selected)
Thanks @PikachuEXE for pointing out the issue. I have tried to resolve it. Please let me know if any other bug remains in it.
- Set
Video Playback Rate Intervalto0.1 - Try to set
Default Playback Rateto0.1 - Observe that
Default Playback Rateonly goes to a minimum of0.3
https://github.com/FreeTubeApp/FreeTube/assets/73130443/5888f88a-5f83-4bf6-b9f1-0ca004444fd2
Done