FreeTubeApp
Add gruvbox base theme and gruvbox green color theme
Add gruvbox base theme and gruvbox green color theme
Pull Request Type
- [x] Feature Implementation
Related issue
Closes #3987
Description
I added a gruvbox base theme using the gruvbox colour palette as well as a gruvbox green color theme, I will add more of the color themes if the pr is accepted
Screenshots
Testing
I tested it and I cannot see any issues with the color schemes showing though I have not added all the translations as I only speak english.
Desktop
- OS: GNU/Linux
- OS Version: openSUSE Tumbleweed
- FreeTube version: most up to date one on github
Additional context
I wanted a gruvbox theme for FreeTube and I saw that another issue request did too, it's fine if you (the developers) don't, I was just opening this pr incase it was appropriate.
Also this doesnt fully close the issue because you didnt implement all the gruvbox colors listed in their repo https://github.com/morhetz/gruvbox. The issue also explicitly asks for the light and dark theme implementation.
Would you be open to implementing all the other colors and both themes?
Yes, I will implement both light and dark, I was just checking if this pr is appropriate. I'll fix the secondary colour issue right now, Thanks
Ok, so the reason the secondary colours were not working properaly was because I did not add the "--accent-color-opacity1 - 4" so I added that and I think it's fixed though I haven't added the gruv light theme yet.
By the way, I'm not sure how to make the icons for it so mine were a bit thrown together and look not great, so yeah.
So I added all the colour themes as well @efb4f5ff-1298-471a-8973-3d47447115dc
I tested the themes and cannot see any issues (I fixed the secondary colour scheme issue you raised)
Though I still have not added translations and the logos look bad as I don't know how to make them for the theme.
So I added all the colour themes as well @efb4f5ff-1298-471a-8973-3d47447115dc I tested the themes and cannot see any issues (I fixed the secondary colour scheme issue you raised) Though I still have not added translations
Can confirm that the issue is fixed and cant find any other issues at the moment :)
You dont have to add the translations for en_Gb as the translators will do that for you.
the logos look bad as I don't know how to make them for the theme.
Maybe previous contributors can give you some guidance on that. Summoning previous contributors that created PR's for adding themes: @codysechelski @Rekit0 @JonahFoster
@DeaDvey For the logos, what I did was upload it to Photopea and just replace the colors on the main logo. You can find a ton of videos and blogs online about photopea, and here are some Reddit comments that might be helpful. Feel free to reach out if you have any specific questions
Thanks, I'll check out Photopea, I think gimp worked for me here though, for future note, I used the colorise tool to change the colour of the whole thing to #ebdbb2 and #282828
And I realised the en_GB was not needed, I added that first as that's the one I thought to add first (I'm british) but realised en-US would be better.
When #4898 will be merged you have some higher quality icons available. I would recommend to redo your icons based on those enhanced ones
Not ready right now, one of the logos is showing as dark in dark mode and the main and secondary themes don't seem to be showing, can't work on it until tomorrow though. I did implement SVG images though which seem to work.
Looks good to me, can't see any issues with the svgs loading and they're the correct ones.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi, I fixed the colour contrast issues mentioned but I wasn't 100% sure on the ft-share-button thing, I think I did what you requested but you'll have to check. I also noticed a conflicting file so updated mine to incorporate the changes but I don't have write access to resolve the conflict.
You can resolve the conflict with a merge or rebase with the development branch.
Hi, I fixed the colour contrast issues mentioned but I wasn't 100% sure on the ft-share-button thing, I think I did what you requested but you'll have to check.
What this governs is what version of the Invidious and YouTube logos show when you click the "Share" icon under a video. If the logo is too dark / bright to see with a given base theme, it means it needs to put it in with either the dark or light colors in that file. I haven't checked on this yet, but from a brief scan at the file, it seems like you got it.
Is resolving conflict the only thing that is left todo?
From what I can see, yes! As a reminder in case my message above was missed:
You can resolve the conflict with a merge or rebase with the development branch.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
@DeaDvey Could you please rebase/merge with development one more time and remove the changes to yarn.lock?
Conflicts have been resolved. A maintainer will review the pull request shortly.
Oh yeah, thanks that worked, the themes all show correctly, solarized looks great too! 👍
Thanks for identifying these @efb4f5ff-1298-471a-8973-3d47447115dc. Seems like #fbf1c7 should be changed to something else with a higher color contrast, from the looks of it. That and maybe having a separate bg-color and card-bg-color for gruvboxLight.
This pull request has conflicts, please resolve those before we can evaluate the pull request.