Upgrade electron from 16 > 20

[PikachuEXE]

Pull Request Type Please select what type of pull request this is:

• [x] Feature Implementation

Related issue Might or might not fix issue in #2113

Closes #2358

Description 16.x is not supported anymore From https://www.electronjs.org/blog/electron-17-0

Breaking change in 17.x =

• desktopCapturer.getSources
• The end

Breaking change in 18.x =

• Removed nativeWindowOpen
• The end

Breaking change in 19.x

Breaking change in 20.x

Screenshots (if appropriate) N/A

Testing (for code that is not small enough to be easily understandable) Use test build daily in different OS

Desktop (please complete the following information):

• OS: MacOS
• OS Version: 12.1
• FreeTube version: f9870f431c0111981062ec3ccfcf8c88a04a88d1

Additional context Add any other context about the problem here.

[wildwestrom]

Just compiled from source and am using now. If you want to compile this on Arch, you need the libxcrypt-compat package. I also did this so as not to do extra work.

diff --git a/_scripts/build.js b/_scripts/build.js
index 14ce4fcd..63b8fffa 100644
--- a/_scripts/build.js
+++ b/_scripts/build.js
@@ -33,7 +33,7 @@ if (platform === 'darwin') {
     arch = Arch.armv7l
   }
 
-  targets = Platform.LINUX.createTarget(['deb', 'zip', 'apk', 'rpm', 'AppImage', 'pacman'], arch)
+  targets = Platform.LINUX.createTarget(['pacman'], arch)
 }
 
 const config = {
@@ -97,7 +97,7 @@ const config = {
   linux: {
     category: 'Network',
     icon: '_icons/icon.svg',
-    target: ['deb', 'zip', 'apk', 'rpm', 'AppImage', 'pacman'],
+    target: ['pacman'],
   },
   // See the following issues for more information
   // https://github.com/jordansissel/fpm/issues/1503

After that, you can:

cd build
sudo pacman -U freetube*.pacman

[PikachuEXE]

I think the main potential issue source would be linux...

[wildwestrom]

So far so good on my setup; Sway/wlroots.

@PikachuEXE I think the main potential issue source would be linux...

It's just a Chromium browser with some node support. Are we using any weird features of Chromium or V8? Nothing about FreeTube seems very outside the realm of a typical web app.

[efb4f5ff-1298-471a-8973-3d47447115dc]

When u hover over the PIP window with your cursor

https://user-images.githubusercontent.com/73130443/183025711-749467b9-66d7-4247-9302-b298736c93be.mp4

Is this included in the breaking changes? I'm on Ubuntu everything works fine apart from this.

Edit: I'm willing to make this sacrifice and approve this PR so other users can finally enjoy FT on Wayland instead of seeing black screen.

[PikachuEXE]

I think it's a bug, have you tried 19.x version?

[PikachuEXE]

19.x also got the same issue, but 18.x does not

[ChunkyProgrammer]

Wait for https://github.com/electron/electron/issues/34406 to ve fixed before merging?

https://github.com/electron/electron/pull/35034

[toby63]

Tested on Manjaro Linux and except for the already mentioned color problem (in https://github.com/FreeTubeApp/FreeTube/pull/2448#issuecomment-1206354346), I could not find any issues yet.

[ChunkyProgrammer]

new electron version released (20.0.3), not fixed yet (will hopefully be fixed for next electron version)

[efb4f5ff-1298-471a-8973-3d47447115dc]

FYI https://github.com/electron/electron/pull/35034 has been merged we only need to wait for new version to be pushed out!

[PikachuEXE]

I subscribe to released not PR merges... :P Coz I can't update until they are released!

Wait should I also open a PR for electron 21...?

[efb4f5ff-1298-471a-8973-3d47447115dc]

21 will be released in 5 weeks 3 weeks ago 20 was released Every 8 weeks new electron version being released.

So no u dont have to create a PR for 21 yet...

Hopefully we can enjoy 20 for a little while.

[PikachuEXE]

PIP fix included Should we remove the WIP label?

[PikachuEXE]

@ChunkyProgrammer @absidue

Also why @ChunkyProgrammer you just remove the label but not review 🤣