FreeCAD-addons icon indicating copy to clipboard operation
FreeCAD-addons copied to clipboard

GitPython may not be installed but what if user prefers GitPython over downloading the .zip from Github

Open luzpaz opened this issue 7 years ago • 3 comments

If installing a WB via the Addon Manager and user doesn't have the GitPython package installed, the output will show the following:

No module named git
GitPython not found. Using standard download instead.
Downloading https://github.com/tomate44/CurvesWB/archive/master.zip

Lets give the user the option to choose if they want to have GitPython installed.

Two ways to do this:

  1. Notify the user in a dialog that GitPython is not installed and that is optional since there are other methods to download. Nevertheless, if they are interested here are the instructions to download GitPython etc...
  2. Perhaps use the soon-to-be-integrated pip install methodology to prompt the user if they want to install GitPython

luzpaz avatar Sep 07 '18 22:09 luzpaz

For the VS2013 builds it is difficult to make this work (the problem is PY2) For PY3 with VS2015+, this will be possible per 2.

sgrogan avatar Sep 07 '18 23:09 sgrogan

Option 2 is going to be a reasonable path forward following the merge of https://github.com/FreeCAD/FreeCAD/pull/5376

chennes avatar Jan 12 '22 21:01 chennes

We now no longer depend on GitPython, so this is not relevant. You do need to have git installed, but we can't do that automatically, so the best we could do is warn the user they "need" it.

chennes avatar Sep 21 '22 20:09 chennes

Where are we at with this then ?

luzpaz avatar Jan 05 '23 18:01 luzpaz

From my point of view it's dead in the water: if you want to use git to download addons, you have to install git. I'm not sure what sort of meaningful user interface option I could provide.

chennes avatar Jan 05 '23 22:01 chennes