ScriptPlayer icon indicating copy to clipboard operation
ScriptPlayer copied to clipboard

Feature Request - Support subtitles from .mkv containers

Open Theletha opened this issue 4 years ago • 12 comments

Would be great to support subbs (.ass, .ssa) so i dont have to hardsub them into mp4's

Theletha avatar Oct 09 '21 19:10 Theletha

Hmm ... I don't think I know how to get those from the video file. I might be able to get SRTs working, but extracting those from an MKV container might be a future "FFMPEG only" feature.

FredTungsten avatar Oct 13 '21 16:10 FredTungsten

Sooo apparently you just have to extract an SRT file from the mkv and it automatically works. The DirectVobSub Filter (don't know if this is installed by default or if you need a codec pack) takes care of everything automatically ...

You can do this with ffmpeg like this:

ffmpeg -i videoname.mkv videoname.srt

Alternatively Subtitles can be activated with LAV Splitter (again - if it's installed) without any additional work.

I'll still try to add this as a feature, but I think there are plenty of workarounds for advanced users that don't require hardcoding the subs.

FredTungsten avatar Oct 14 '21 18:10 FredTungsten

hm haven't seen a .srt file in a long time. its mostly .ass & .ssa files now.

Thanks so far!

Theletha avatar Oct 14 '21 19:10 Theletha

@FredTungsten is There any progress?

woojh3690 avatar Oct 03 '22 18:10 woojh3690

@FredTungsten is There any progress?

A tiny bit - might pick it up again sometime

FredTungsten avatar Oct 03 '22 18:10 FredTungsten

There is no other way play funscript with subtitles. So thanks to not give up.

woojh3690 avatar Oct 03 '22 18:10 woojh3690

Indeed thanks for still having it in mind!

Theletha avatar Oct 07 '22 08:10 Theletha

I just implemented very very basic subtitle support in the latest beta build

  • Should work with simple ass, ssa and srt files
  • For now only external files, not the ones included in containers (e.g. mkv)
  • No settings
  • No text formatting

FredTungsten avatar Oct 10 '22 15:10 FredTungsten

Hello, could you give a bit more color on how to get the subtitles to work? I downloaded latest beta (1.2.0.421), made sure subtitles are enabled in options and tried on a video with a .srt file of same name in the folder but can't see any subtitles. Also when files are loaded I can see video and funscript being loaded but no message about srt being loaded, not sure whether there should be one. Thanks!

rbwabd avatar Feb 10 '23 11:02 rbwabd

That's all you should need to do (enabling subtitles and making sure they have the same name). If it works, there will be an on-screen message - either "Subtitles extracted from video XY" or "Subtitles loaded from file"

Latest version is 1.2.0.405

Was that a typo or did you download a 1.2.0.421 somewhere else?

FredTungsten avatar Feb 10 '23 12:02 FredTungsten

it was a typo! somehow i remembered the number wrong. thanks for super fast reply! i'll mess around bit more with the file see if I can get it to work.

rbwabd avatar Feb 10 '23 12:02 rbwabd

I checked that the ASS subtitle file looks normal, but the srt subtitle file does not work. Please check. my version is 1.2.0.405 and 1.2.0.406 thanks~

smreo3839 avatar Feb 24 '23 09:02 smreo3839