GAPointNet icon indicating copy to clipboard operation
GAPointNet copied to clipboard

Slight difference between implementation and paper.

Open AI-Guru opened this issue 6 years ago • 2 comments

Namaste!

I think this is my final issue :D

In the implementation of the classifier, you start with a single-head-attention, then you do the spatial transformation followed by multi-head-attention. In the paper, on the other hand, you start with the transformation.

I have the feeling that I have missed something. What is your opinion?

AI-Guru avatar Nov 06 '19 14:11 AI-Guru

Another difference. Correct me if I am wrong: The implementation of attn_feature does not 100% match. Especially "edge_feature = input_feature_tiled - neighbors" seems to be missing on the picture.

AI-Guru avatar Nov 06 '19 16:11 AI-Guru

Yes. The paper mentions that a single-head attention happens as part of the spatial transform step.

AI-Guru avatar Nov 09 '19 15:11 AI-Guru