Foundatio.AzureStorage icon indicating copy to clipboard operation
Foundatio.AzureStorage copied to clipboard

Compress blobs before saving them; uncompress on read

Open benaadams opened this issue 4 years ago • 3 comments

Addresses https://github.com/exceptionless/Exceptionless/issues/353

benaadams avatar Mar 01 '21 20:03 benaadams

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 01 '21 20:03 CLAassistant

Checks ran too fast; is it not picking up the AzureStorageConnectionString connection string value?

benaadams avatar Mar 01 '21 20:03 benaadams

I've been thinking about this and I'm not sure if it's a good idea. If I store blobs in azure storage uncompressed, then I can use any storage client to go look at those files and download them, etc. If I am compressing them, I lose that ability. Also, it just seems like compression should be the choice of the caller and that we shouldn't force compression on every blob. That being said, I don't know how this impacts performance. Could we do the same thing you are doing with renting buffers from the caller side? Or maybe we could make this an option where you could turn on compression and it would do this for every blob like you are doing in this PR. Thoughts?

ejsmith avatar Mar 02 '21 14:03 ejsmith