Phone icon indicating copy to clipboard operation
Phone copied to clipboard

Additional language on dialpad

Open Belyavin opened this issue 2 years ago • 7 comments

Fixes FossifyOrg/Phone#47

Belyavin avatar Jan 21 '24 19:01 Belyavin

Letters in both languages should be centered (e.g. 3 looks really bad).

image

Aga-C avatar Jan 21 '24 20:01 Aga-C

@Aga-C also the height of the lowest row of keys is different, which looks weird.

And also # and * are not vertically aligned with the 0, but this is also the case on the master branch. Might be a different PR?

derrohrbach avatar Jan 22 '24 21:01 derrohrbach

I've changed the string to a common one, and aligned the text to the center. I also aligned * and # to 0, though I'm not sure if it became better, need you opinion on this.

Belyavin avatar Jan 23 '24 19:01 Belyavin

New text alignment

Belyavin avatar Jan 23 '24 19:01 Belyavin

Hi, are we waiting for something before merging?

Belyavin avatar Feb 23 '24 12:02 Belyavin

@Belyavin You have to wait for the final review from Naveen.

Aga-C avatar Feb 23 '24 13:02 Aga-C

I also aligned * and # to 0, though I'm not sure if it became better, need you opinion on this.

@Belyavin indeed * and # look better when centered, I reverted that change.

naveensingh avatar Mar 18 '24 01:03 naveensingh