FossifyOrg
WIP: Initial support for sim colors
Here is my initial draft for sim color support. Feel free to already comment on it. Things left to do:
- [ ] Move sim color conversions to commons library, so we can use it in SMS app too
- [x] Test with more designs
- [x] Check/Work on CallActivity and ConferenceActivity
- Maybe also rework SelectSIMDialog (most likely seperate PR)
This fixes/implements: https://github.com/SimpleMobileTools/Simple-Dialer/issues/322
@derrohrbach I'll check this soon...
If the PR isn't ready to merge yet, you can convert it to a draft PR to signal that.
@naveensingh Hey, thanks. I did not know that, since I'm used to the GitLab workflow where you just name your MR "WIP".
Only thing missing is moving the extension function to the common library. What is the workflow for that? Do I first submit a PR there and wait for a version to be built/published so i can update the reference in this project?
Or should I just copy this one function over to the SMS app?
@derrohrbach
What is the workflow for that? Do I first submit a PR there and wait for a version to be built/published so i can update the reference in this project?
Please raise a PR in Commons. Once the PR is merged, anyone can trigger a Jitpack build at this page: https://jitpack.io/#org.fossify/commons/