FossifyOrg
Clarify unknown vs hidden numbers
Checklist
- [x] I made sure that there are no existing issues - open or closed - to which I could contribute my information.
- [x] I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
- [x] I have read the FAQs inside the app (Menu -> About -> FAQs), in the README and my problem isn't listed.
- [x] I have taken the time to fill in all the required details. I understand that the request may get dismissed otherwise.
- [x] This issue contains only one feature request.
Which apps should have this feature?
Phone, Messages
Feature description
In (Phone) Settings -> Manage blocked numbers, there's 2 options:
- Block calls from unknown numbers
- Block calls from hidden numbers
Why do you want this feature?
- blockUnknownNumbers is used when number is not null but doesn't exist in contacts https://github.com/FossifyOrg/Phone/blob/9979f93c844d9024a05316c49d74a579d9b6eb81/app/src/main/kotlin/org/fossify/phone/services/SimpleCallScreeningService.kt#L23-L29
- blockHiddenNumbers is used when number is null https://github.com/FossifyOrg/Phone/blob/9979f93c844d9024a05316c49d74a579d9b6eb81/app/src/main/kotlin/org/fossify/phone/services/SimpleCallScreeningService.kt#L31-L33
But elsewhere isUnknownNumber refers to when number is null
https://github.com/FossifyOrg/Phone/blob/9979f93c844d9024a05316c49d74a579d9b6eb81/app/src/main/kotlin/org/fossify/phone/helpers/RecentsHelper.kt#L175-L178
Historically at least where I'm from, calls without a phone number are referred to as unknown callers.
In the call log/history in Fossify Phone, and every other phone or app I've seen, if you get a call which doesn't have a phone number it says "Unknown"
In my opinion, I think calls without a number should be referred to as Unknown, while calls which don't exist in contact should be referred to as something else.
Additional information
https://github.com/FossifyOrg/Phone/discussions/343
