Enhance Filters (Invoke-FGTRestMethod)

[Tuurtje]

There was something wrong with the parameter sets. Somehow they need to be on the same line as "mandatory", else all options are visible in every parameterset.

Also added the remaining filter type's (because i needed them).

[alagoutte]

Hi Arthur,

Thanks, All Filter work ?!

Yes, it is strange for filter... (i really need to add some test...)

[Tuurtje]

Yeah tested them all. they all seem to work.

[alagoutte]

Thanks, i will check !

[alagoutte]

Thanks Arthur, can you add name of file on commit message ? ippool: Fixed ParameterSets and added filter types

for example (or make a big commit with all change) it is very strange, i don't work if you set the parametername outside of first Parameter

[Tuurtje]

Will do next time. I made the same change in all file. Don't know how to do this in one commit.

---

Van: Alexis La Goutte [email protected] Verzonden: dinsdag 14 april 2020 08:16 Aan: FortiPower/PowerFGT [email protected] CC: Arthur Heijnen [email protected]; Author [email protected] Onderwerp: Re: [FortiPower/PowerFGT] Enhance Filters (Invoke-FGTRestMethod) (#95)

Thanks Arthur, can you add name of file on commit message ? ippool: Fixed ParameterSets and added filter types

for example (or make a big commit with all change) it is very strange, i don't work if you set the parametername outside of first Parameter

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/FortiPower/PowerFGT/pull/95#issuecomment-613294845, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABQAF77EKVSLJIWBZW4KOJDRMQLVFANCNFSM4MFJYI7A.

[alagoutte]

What tools do you are using for git ?

only need to make a git add of all file (or use git commit -a) after make change all files

(you can also use git rebase -i master and reword/squash/fixup and after need to make a git push -f for force)

[Tuurtje]

Copy past in webbrowser :-( I've got github desktop installed. will check the howto.

---

Van: Alexis La Goutte [email protected] Verzonden: dinsdag 14 april 2020 08:56 Aan: FortiPower/PowerFGT [email protected] CC: Arthur Heijnen [email protected]; Author [email protected] Onderwerp: Re: [FortiPower/PowerFGT] Enhance Filters (Invoke-FGTRestMethod) (#95)

What tools do you are using for git ?

only need to make a git add of all file (or use git commit -a) after make change all files

(you can also use git rebase -i master and reword/squash/fixup and after need to make a git push -f for force)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/FortiPower/PowerFGT/pull/95#issuecomment-613314910, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABQAF743VQ3NGDKMFAVPVSDRMQQNRANCNFSM4MFJYI7A.

[poundy]

Copy past in webbrowser :-( I've got github desktop installed. will check the howto. … Welcome to that club :) I'm waiting for the 0.5.0 release so I can get back to a state to test and tweak further because I started with copy/paste and not understanding pull requests :)

[alagoutte]

Hi sorry guys but busy for the moment for work on PowerFGT (need to finish 2 other module) I hope get more time end of month and release a new version next month (i will add all external contribution and add tests integration)

I can help you, if you need for git skill

[alagoutte]

Hi Arthur

you can kept open it is always on my todo (but no really in the top !)