victory icon indicating copy to clipboard operation
victory copied to clipboard

Make bars always visible while zooming

Open crcarlo opened this issue 1 year ago • 4 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

Feature Request

If you add a zoom container to a bar chart, bars will disappear as soon as the bar datapoint is outside the new "zoomed" domain.

This makes the the bars appear and disappear as you zoom in and out or pan across the chart.

Can we have the bars rendered if their width is still inside the zoomed domain?

crcarlo avatar Oct 01 '24 10:10 crcarlo

I created a codesandbox we can use to illustrate the issue. With the default dataset, it seems to work as described. Could you fork the sandbox and add data to reproduce the issue?

https://codesandbox.io/p/sandbox/victory-starter-forked-3zd9hc

carbonrobot avatar Oct 01 '24 16:10 carbonrobot

@carbonrobot I think the sanbox is not public as I see a "Sandbox not found" error

crcarlo avatar Oct 01 '24 16:10 crcarlo

Yes, it's right there! It's easier to see by zooming first and then panning. Once the center of the bar is out of the view the whole bar disappears

https://github.com/user-attachments/assets/a4f28103-efec-4b80-8af0-52fc8f809142

crcarlo avatar Oct 01 '24 16:10 crcarlo

Thanks for the video, that describes the issue well. Looks like the clipping path is tied to the grid center point.

carbonrobot avatar Oct 01 '24 18:10 carbonrobot