victory icon indicating copy to clipboard operation
victory copied to clipboard

Refactor and fix brush and zoom behavior

Open becca-bailey opened this issue 3 years ago • 3 comments

We have seen lots of issues come up around brush and zoom behavior, and the brush and zoom becoming out of sync in certain situations. Since it has been difficult to address this issues, VictoryZoomContainer is a good candidate for a refactor.

Let's consolidate some of the discussion around VictoryBrush and VictoryZoomContainer here in order to avoid duplicate issues.

Current issues:

  • Incorrect selections in the brush container when zooming in and out (#2042, #2023)
  • Issues with setting the zoom domain (#1660)
  • Alignment issues (#1451)
  • Issues with time scale (#1560)
  • Panning inconsistencies (#2029, #2083)

This issue most likely depends on the state management milestone.

becca-bailey avatar Feb 15 '22 18:02 becca-bailey

Probably should be looking into this one too since this is being refactored. https://github.com/FormidableLabs/victory/issues/2340

siulca avatar Jul 01 '22 09:07 siulca

Any update on the Zoom and Brush refactor @becca-bailey? Thanks

micmcg avatar Jun 13 '23 00:06 micmcg

Also curious about any updates here @becca-bailey, experiencing the exact same issue as described here https://github.com/FormidableLabs/victory/issues/1541, brushDomain is fully controlled, upon programmatically setting it, the brush does not re-render. The brushDomain is properly updating but x, y, and width values in BrushHandleComponent and BrushComponent are not updating.

Parker-Stafford avatar Jul 14 '23 04:07 Parker-Stafford

This issue scope has expanded greatly, but all the PRs appeared to be merged. I'm going to close this one and we can address any remaining problems in separate issues.

carbonrobot avatar Feb 23 '24 20:02 carbonrobot