spectacle icon indicating copy to clipboard operation
spectacle copied to clipboard

Using props m, p, mx, my, marginBottom etc. on <Text />, <Heading /> doesn't have any effect

Open hinok opened this issue 5 years ago • 1 comments

Describe Your Environment

What version of Spectacle are you using? (can be found by running npm list spectacle)

[email protected]

What version of React are you using? (can be found by running npm list react)

[email protected]

What browser are you using?

chrome

What machine are you on?

macOS / macbook pro

Describe the Problem

https://codesandbox.io/s/simple-spectacle-example-ztd4b?file=/src/index.js

Using props m, mx, my, p, px, py doesn't work for <Text /> and <Heading />.

See generated CSS Zrzut ekranu 2020-05-4 o 22 03 03 Zrzut ekranu 2020-05-4 o 22 04 05

Expected behavior:

It should change padding and margin.

Actual behavior:

padding and margin doesn't change or rules are overriden.

Additional Information

N/A

hinok avatar May 04 '20 20:05 hinok

Consumers overriding our padding/margin default values is currently not supported by the styled-system library.

These are the opened issues related to this problem:

https://github.com/styled-system/styled-system/issues/1136

https://github.com/styled-system/styled-system/issues/1058

https://github.com/styled-system/styled-system/issues/882

christianipanaque avatar Nov 12 '20 00:11 christianipanaque