FormidableLabs
react-native-orientation-listener improvements
I am interested in using your lib in production but the native dependency seems quite broken on Android at least, it is way too sensitive for the purposes that we need which causes a lot of unnecessary work on the JS thread.
I am undecided on how to improve the situation, should I add a native component to this lib or fork react-native-orientation-listener and fix it there. Notice that I think that the fork would be better for this library but worse if you actually want the sensitivity so I don't think it should be merged upstream.
Are you interested in having the native part in the repo or would you rather keep the native part separated?
@ruiaraujo thanks for taking interest in this library! I've been planning on replacing react-native-orientation-listener with the better maintained react-native-orientation module.
You could check if the other module works better. If it does, I'll happily accept a PR to switch to it!
@jevakallio conceptually react-native-orientation aligns with what I had in mind for Android so that is a start. I will take a look, thanks.
@jevakallio To be honest while it is a better library, I would not say it is better maintained. No commits since August with a lot of open PRs. I got something working but I had to fork the native library. Do you mind if the PR points to this fork?
@ruiaraujo what are the changes that were needed in the native library? If they were something that could benefit other users of react-native-orientation, it would be great if you could contribute those changes upstream. It's a popular library, and any improvements there will benefit many.
I'm hesitant to consider depending on a fork here, but let's have that discussion if you think that your native changes are not viable in upstream.
I am will be definitely be upstream all the changes, it is just I do not foresee them getting merged since the project seems abandoned.
@ruiaraujo can you open a PR against react-native-orientation anyway, let's see if we can get it moving
@jevakallio The biggest thing is that the published version does not even include the changes on master that is supposed to have hence my abandoned tag on the project.
Thanks! I'm trying to contact the react-native-orientation maintainer to get this moving forward.
@ruiaraujo I've got the commit bit to react-native-orientation now. There's rich irony in that I'm way too busy right now to land large changes to an unfamiliar codebase, but I will try to get to it shortly.