react-native-owl icon indicating copy to clipboard operation
react-native-owl copied to clipboard

chore: update example RN version

Open robwalkerco opened this issue 3 years ago • 0 comments

Description

This PR updates the example app to a more recent version, and fixes an issue that was causing the tests to fail on Android when using RN version 0.69.x.

Closes #119

I attempted to get the Android CI tests to run, but ran into issues with the Java Version emulator compatibility, so I've disabled the Android CI again for now so that we can fix the Android issues in the library as a priority. Android tests can be run locally for the time being.

I've tried to update to 0.70.1, but the tests fail to run on Android.

It seems that our current monkey patching method doesen’t work with RN 0.70.0. I guess when we import React in Owl it’s a different React that the app gets (though I’ve checked the version of both and they are the same).

Looking at why-did-you-render for inspiration, and they get the user to add some init code to the very start of their app index.js file that inits the project and passes in React (Setup docs).

We may want to test out something similar. It would make the initial setup slightly more involved but would guarantee we are patching the correct instance of React. This would be a breaking change, unless we can find another way to get it to work.

robwalkerco avatar Sep 19 '22 08:09 robwalkerco