freactal
freactal copied to clipboard
Enhancement: Add `finalize` effect, triggered on unmount (symmetry with `initialize`)
The maintainers of this repo require that all pull request submitters adhere to the following:
- [x] I have read and will comply with the contribution guidelines. (required)
- [x] I have read and will comply with the code of conduct. (required)
- [x] All related documentation has been updated to reflect the changes made. (required)
- [x] My commit messages are cleaned up and ready to merge. (required)
The maintainers of this repository require you to select the semantic version type that the changes in this pull request represent. Please select one of the following:
- [ ] major
- [x] minor
- [ ] patch
- [ ] documentation only
maintainerd logging is enabled for this repository.
All actions related to rules and their enforcement will be logged here as a permanent record.
Click to view log...
-
2018-08-21T23:33:31.882Z:b85b485: The pull request was created -
2018-08-21T23:35:44.458Z:b85b485: @agurtovoy checkedI have read and will comply with the [contribution guidelines](https://github.com/FormidableLabs/freactal/blob/master/CONTRIBUTE.md).. -
2018-08-21T23:35:48.316Z:b85b485: @agurtovoy checkedAll related documentation has been updated to reflect the changes made. _(required)_. -
2018-08-21T23:36:22.003Z:b85b485: @agurtovoy checkedI have read and will comply with the [code of conduct](https://github.com/FormidableLabs/freactal/blob/master/CONTRIBUTE.md).. -
2018-08-21T23:43:59.494Z:b85b485: @agurtovoy selectedminoras the semantic version. -
2018-08-21T23:44:02.777Z:b85b485: @agurtovoy checkedMy commit messages are cleaned up and ready to merge. _(required)_.
Not sure why maintainerd is complaining about cc4ba78; it does have an empty second line. Maybe an old version of maintainerd (https://github.com/divmain/maintainerd/issues/1?)