bootstrap-dark icon indicating copy to clipboard operation
bootstrap-dark copied to clipboard

dark-variables colors not respected in toggle-bootstrap-dark

Open cVantez opened this issue 4 years ago • 1 comments

Since the bootstrap variables partial needs to be loaded first, the overrides of the color variables in dark-variables are not picked up by the $colors or $theme-colors maps. This in turn means the utility classes generated from those maps don't properly reflect the dark theme colors.

For example: toggle-bootstrap-dark.css line 2077-9:

.bootstrap-dark .btn-primary {
  color: #ced4da;
  background-color: #007bff;

But #007bff is the default blue, not the lightened version specified. It's possible this issue may affect other dark stylesheets, toggle-bootstrap-dark is just the one I've been using.

I believe this could be fixed by adding something like

$colors: () !default;
$colors: map-merge(
  (
    "blue": $blue,
    ...
  ),
  $colors
);

to _dark-variables.scss

cVantez avatar Dec 11 '21 00:12 cVantez

Thanks for reporting this issue. I'll investigate when I get the chance.

Carl-Hugo avatar Dec 12 '21 21:12 Carl-Hugo

I totally forgot about this issue; fixing it atm.

Carl-Hugo avatar Nov 16 '22 01:11 Carl-Hugo

PR #58 addresses this.

Carl-Hugo avatar Nov 16 '22 22:11 Carl-Hugo