FlxPeters
fix: netbox 4.2 migrat site => scope for virtual machine clusters
Fix for issue https://github.com/FlxPeters/netbox-plugin-prometheus-sd/issues/212
@FlxPeters any timeline on getting this merged and a release created? Without it the plugin does not work on Netbox 4.2.x
Sorry for the delay, I was a bit absent the last weeks due to different other things.
I will have a look at this soon since we also aim to update on the latest version.
@augustine-censys-io I just added the latest Netbox versions to the CI pipeline. Can you please rebase the MR and check if the code still works? Please also make sure older versions of Netbox still works as expected. Best case would be a dedicated test for a VM with scope and one with site.
Thanks for your contribution!
Is there anything I can do to speed up this PR? We rely on this plugin so if there's anything I can do to get it fixed, I'd be happy to help.
Sure, the current code is missing tests for the new structure. I would be glad to merge it as soon as we have everything in place
@FlxPeters I see that the old Netbox versions (pre 4.2) are being tested. Do we intend for the latest plugin version to work with older Netbox versions?
Yes, the Ci pipeline defines the current supported versions. Goal is to have at least the latest relevant minor versions of netbox
No problem. I updated the MR to make the plugin backwards compatible with older Netbox versions. The changes in this MR don't work with pre Netbox 4.2. I tested against Netbox 4.0.11, 4.1.11 and 4.2.5 locally, and all the tests are passing.