rurusetto-addon icon indicating copy to clipboard operation
rurusetto-addon copied to clipboard

Make it not crash on android

Open trustytrojan opened this issue 1 year ago • 2 comments

The usual deal of the lazer APK trimming out unused classes/methods from the bundled .NET runtime Still have this one left but it isn't causing a crash upon pressing the report/webpage buttons on ruleset details.

System.MissingMethodException: Method not found: void osu.Game.OsuGame.OpenUrlExternally(string,bool)

trustytrojan avatar Apr 09 '25 20:04 trustytrojan

Why are we not using GetEndpoint anymore? String concat with paths is very error prone. Otherwise I think it looks good.

Flutterish avatar Apr 10 '25 12:04 Flutterish

Why are we not using GetEndpoint anymore? String concat with paths is very error prone. Otherwise I think it looks good.

Changed it back, no effect on behavior. Made the change because OsuJsonWebRequest's constructor only accepted a string and I didn't know about the AbsoluteUri property on Uri objects.

trustytrojan avatar Apr 16 '25 19:04 trustytrojan