embedded-time icon indicating copy to clipboard operation
embedded-time copied to clipboard

Release/v0.13.0

Open PTaylor-us opened this issue 4 years ago • 9 comments

Features

  • [x] Generic add/sub
  • [ ] ~sub-unity units (milli, micro, etc)~ (pushing to later release)
  • [ ] feature support for defmt

Changes

  • [x] consistent integer() return types

PTaylor-us avatar Aug 28 '21 19:08 PTaylor-us

Great to see this getting released!

korken89 avatar Sep 02 '21 13:09 korken89

On my machine read_timer test fails time to time.

running 4 tests
test periodic_expiration ... ok
test oneshot_wait ... ok
test read_timer ... FAILED
test periodic_wait ... ok

failures:

---- read_timer stdout ----
thread 'read_timer' panicked at 'assertion failed: `(left == right)`
  left: `Ok(Seconds(1))`,
 right: `Ok(Seconds(0))`', tests/timer.rs:105:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    read_timer

test result: FAILED. 3 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

burrbull avatar Oct 06 '21 12:10 burrbull

On my machine read_timer test fails time to time.

@burrbull That sounds like a timing issue if the tests are run multithreaded. Using the --test-threads=1 option may clear this up. (see https://github.com/FluenTech/embedded-time/blob/master/.github/workflows/ci.yml)

PTaylor-us avatar Oct 16 '21 20:10 PTaylor-us

Any news on when this might get released? I can't upgrade rtic to 1.0 without the changes in this branch.

ZoeyR avatar Jan 04 '22 15:01 ZoeyR

Any news on when this might get released? I can't upgrade rtic to 1.0 without the changes in this branch.

RTIC 1.0 depends on fugit, not embedded-time

burrbull avatar Jan 04 '22 15:01 burrbull

Any news on when this might get released? I can't upgrade rtic to 1.0 without the changes in this branch.

RTIC 1.0 depends on fugit, not embedded-time

According to this: https://github.com/rtic-rs/cortex-m-rtic/issues/578 that is not the case

ZoeyR avatar Jan 04 '22 16:01 ZoeyR

Both work :)

korken89 avatar Jan 04 '22 16:01 korken89

It's been a year since this PR was opened and 8 months since the last comment, how's progress going on this release? Is there anywhere that needs additional assistance I or others may be able to provide to get this to the finish line?

Particularly I'm in need of the change for the Generic duration not implementing FixedPoint, which in my case blocks me from doing clock.new_timer(generic_duration).

ghost avatar Aug 21 '22 17:08 ghost