fix: return proper status codes for invalid/non-existent chatflow IDs
- Add UUID validation to return 400 for invalid ID format
- Preserve InternalFlowiseError status codes (404 for not found)
- Fix error handling to prevent wrapping all errors as 500
Fixes #5379
Summary of Changes
Hello @aibysid, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refines the error handling mechanism for retrieving chatflows by ID. It introduces validation for the UUID format of chatflow IDs, ensuring that requests with malformed IDs receive an appropriate 400 status. Additionally, it enhances the error propagation to correctly preserve specific error codes like 404 for non-existent chatflows, thereby providing more accurate feedback to the client and preventing generic 500 errors for client-side issues.
Highlights
- UUID Validation: Implemented UUID format validation for chatflow IDs, returning a 400 Bad Request status for invalid ID formats.
- Error Code Preservation: Ensured that existing InternalFlowiseError status codes, such as 404 for not found, are preserved and re-thrown, rather than being wrapped as generic 500 errors.
- Refined Error Handling: Improved the error handling logic to prevent all errors from being caught and re-thrown as 500 Internal Server Errors, allowing more specific error responses.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.
I would add that this error also happens for many APIs and not only for the chatflow API, a more global fix could be applied
I would add that this error also happens for many APIs and not only for the chatflow API, a more global fix could be applied
Agreed will plan on doing it with next commit.