flagsmith icon indicating copy to clipboard operation
flagsmith copied to clipboard

fix: Use data instead of parsed data for recording analytics

Open existentialcoder opened this issue 3 months ago • 10 comments

Thanks for submitting a PR! Please check the boxes below:

  • [ ] I have added information to docs/ if required so people know about the feature!
  • [x] I have filled in the "Changes" section below?
  • [x] I have filled in the "How did you test this code" section below?
  • [x] I have used a Conventional Commit title for this Pull Request

Changes

  • This method of django does not parse the feature keys with . righly (Refer #5906 for the exact error)
  • This will fix the same.
  • Used initial_data instead of validated_data which has the wrong parsed format

Please describe.

How did you test this code?

Manual API testing

existentialcoder avatar Oct 23 '25 21:10 existentialcoder

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on November 10.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

cursor[bot] avatar Oct 23 '25 21:10 cursor[bot]

@existentialcoder is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 23 '25 21:10 vercel[bot]

@matthewelwell Apologies for the delay. Let me know if this would work!

existentialcoder avatar Oct 23 '25 21:10 existentialcoder

Hi @existentialcoder, thanks for the contribution! Can you make sure that the tests pass (see here) and I'll review it once that's done. Thanks!

matthewelwell avatar Oct 24 '25 09:10 matthewelwell

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 98.01%. Comparing base (57f0e97) to head (eea586b). :warning: Report is 55 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6196      +/-   ##
==========================================
+ Coverage   97.99%   98.01%   +0.01%     
==========================================
  Files        1278     1278              
  Lines       44927    45151     +224     
==========================================
+ Hits        44028    44253     +225     
+ Misses        899      898       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 24 '25 15:10 codecov[bot]

Hi @existentialcoder, thanks for the contribution! Can you make sure that the tests pass (see here) and I'll review it once that's done. Thanks!

Addressed. I guess it's only the vercel complaints now

existentialcoder avatar Oct 24 '25 18:10 existentialcoder

Hi @existentialcoder, thanks for the contribution! Can you make sure that the tests pass (see here) and I'll review it once that's done. Thanks!

Addressed. I guess it's only the vercel complaints now

Were you able to check? @matthewelwell

existentialcoder avatar Oct 28 '25 07:10 existentialcoder

Thanks 👍

Might have fixed the build one more time. Can you check again, sorry :) @Zaimwa9

existentialcoder avatar Oct 28 '25 14:10 existentialcoder

Thanks 👍

Might have fixed the build one more time. Can you check again, sorry :) @Zaimwa9

Just a reminder. Thanks :)

existentialcoder avatar Oct 29 '25 14:10 existentialcoder

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs Ignored Ignored Preview Nov 3, 2025 10:12am
flagsmith-frontend-preview Ignored Ignored Preview Nov 3, 2025 10:12am
flagsmith-frontend-staging Ignored Ignored Preview Nov 3, 2025 10:12am

vercel[bot] avatar Nov 03 '25 10:11 vercel[bot]