chore: restrict external HTTP calls in tests
Thanks for submitting a PR! Please check the boxes below:
- [x] I have run
pre-committo check linting - [ ] I have added information to
docs/if required so people know about the feature! - [x] I have filled in the "Changes" section below?
- [x] I have filled in the "How did you test this code" section below?
- [x] I have used a Conventional Commit title for this Pull Request
Changes
This PR adds a global restriction of HTTP requests in unit tests. When an external HTTP call is detected, the test trying to perform it fails with a notice/instruction to developers.
This PR will also add fixes to the current offending tests.
How did you test this code?
Ran the test suite.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 7, 2024 1:45pm |
| flagsmith-frontend-preview | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 7, 2024 1:45pm |
| flagsmith-frontend-staging | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 7, 2024 1:45pm |
Uffizzi Preview deployment-51096 was deleted.
Codecov Report
Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.
Project coverage is 95.87%. Comparing base (
53e728a) to head (9001537).
| Files | Patch % | Lines |
|---|---|---|
| api/conftest.py | 90.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #3866 +/- ##
==========================================
- Coverage 95.87% 95.87% -0.01%
==========================================
Files 1133 1133
Lines 35873 35883 +10
==========================================
+ Hits 34393 34402 +9
- Misses 1480 1481 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@matthewelwell This is now ready for review.