bob icon indicating copy to clipboard operation
bob copied to clipboard

references: add offset to pull

Open Fishrock123 opened this issue 6 years ago • 4 comments

Refs: https://github.com/Fishrock123/bob/issues/23

Fishrock123 avatar Jun 05 '19 23:06 Fishrock123

If you add an offset to pull() it makes sense to also add an offset to next()

Raynos avatar Aug 06 '19 09:08 Raynos

@Raynos You mean to note where that particular read was done from?

Fishrock123 avatar Aug 06 '19 17:08 Fishrock123

Correct, to note at which offset the n bytes where read into the buffer.

But this raises a good question, what does offset on pull() mean ? the offset to read into in the buffer or the offset to read from in whatever the source is ( like an offset in a file on disk ).

Raynos avatar Aug 06 '19 17:08 Raynos

It was supposed to be source read location. I am still not really sure this fits well into the stream abstraction...

Fishrock123 avatar Aug 06 '19 17:08 Fishrock123