spark icon indicating copy to clipboard operation
spark copied to clipboard

Storage the Token types of search parameters.

Open whyfate opened this issue 5 years ago • 3 comments

When i read the Spark's source code,I found that the code property was added when saved the searchindex of the boolean type,like this

{
   "active":{
        "code": true 
     }
}

https://github.com/FirelyTeam/spark/blob/stu3/master/src/Spark.Engine/Search/ElementIndexer.cs#L354 and I read the fhir's doc http://build.fhir.org/search.html#token Token search parameters are used for the following data types: booleancodeuriCoding and soon.

but the codeuri not add code property like boolean? https://github.com/FirelyTeam/spark/blob/stu3/master/src/Spark.Engine/Search/ElementIndexer.cs#L190 https://github.com/FirelyTeam/spark/blob/stu3/master/src/Spark.Engine/Search/ElementIndexer.cs#L447 As a result, when querying Token type, a plainStringQueries is required. https://github.com/FirelyTeam/spark/blob/stu3/master/src/Spark.Mongo/Search/Searcher/CriteriaMongoExtensions.cs#L360

It's a question for me. Could give me an answer,thinks.

whyfate avatar Dec 14 '20 12:12 whyfate

Good catch, @whyfate, seems like the indexing for token search parameters should be consolidated so that we handle all token search parameters similar independent of their underlying data type.

kennethmyhra avatar Dec 15 '20 20:12 kennethmyhra

What's your thoughts on this @whyfate, is this something that is time critical to you at the moment? I'm guessing not based on the date for this issue.

If not I will put it into the 2.0 release and then we'll reconsider it then

kennethmyhra avatar Aug 13 '21 13:08 kennethmyhra

It's not important at the moment.

whyfate avatar Aug 16 '21 02:08 whyfate