php-firebird icon indicating copy to clipboard operation
php-firebird copied to clipboard

Fix and re-enable tests/bug46543.phpt

Open Jon4t4n opened this issue 3 years ago • 0 comments

tests/bug46543.phpt was disabled if the PHP version is >= 8.0 in PR #39. We might want to fix and re-enable.

The test verifies that we don't leak memory if we call ibase_trans multiple times with invalid arguments. In older PHP versions, the engine emitted a warning so the script would keep running. But, in PHP 8, we get a fatal error and crash at the first call. So, maybe we don't need this test in newer PHP versions because you can't call the function with invalid arguments.

If we decide to keep this test disabled for PHP 8 and newer, please update the skip message in the test before closing this issue.

Jon4t4n avatar Dec 28 '22 08:12 Jon4t4n