Philippe Rivière

Results 1049 comments of Philippe Rivière

I've implemented extraHead but now I'm thinking that the only thing we need is a flag to cancel the three links, since we can implement the new fonts in the...

I don't like the extra complexity, and suggest #1592 instead.

I believe this is temporary, since #423 wants to detect and preload the default google font (if it's used). (We'll probably have to move font definitions from `global.css` to `font.css`...

To help reviewing I have deployed the project to https://observablehq.observablehq.cloud/framework-example-loader-datawrapper/

I'm sorry I edited my main comment just after I sent it, but you might have read it by email? https://github.com/observablehq/framework/pull/1585#pullrequestreview-2245372013 Also you have removed the "fixed" data/chart.html that I...

If you ask me, I like "Germany is the third-oldest country in the world". But it's only an opinion :)

Should we make a note that the datawrapper iframe does not appear to support dark mode?

I'm a bit reluctant to publish it as is, because there are a few things that ought to be better: *dark mode* I've found a way to enable dark="auto" in...

I've redeployed to https://observablehq.observablehq.cloud/framework-example-loader-datawrapper/ Note that this helper function should be able to accommodate several charts on the page — maybe that's something we could add to the example too.

> what I'd like to do is have a unique code in the script; if a chart with that code already exists, we reuse it, otherwise we populate it We...