Tokenmagic icon indicating copy to clipboard operation
Tokenmagic copied to clipboard

Suggestion: Switch to socketLib to provide awaitable addFilters calls.

Open tposney opened this issue 3 years ago • 2 comments

Currently, if a player client attempts to do deleteFilters (or addFilters) that request is sent to a GM client for execution, however awaiting those calls returns as soon as the message is sent.

Accordingly a second request can be made before the second has been recorded in the database and the second request may end up setting the workingFlags according to the values before the first effect has completed - resulting in an effect being left hanging around.

socketLib supports an awaitable executeAsGM function which only returns when the first deleteFilters has actually completed.

Switching to socketLib would alleviate some race conditions that case DAE pain.

tposney avatar Mar 31 '22 06:03 tposney

Hey Tim! Thank you for your suggestion. I think it's a good idea! Scheduled for the next update.

Feu-Secret avatar Apr 01 '22 21:04 Feu-Secret

Waiting for socketlib to be v10 compatible.

Feu-Secret avatar Sep 15 '22 18:09 Feu-Secret