CoGAPS icon indicating copy to clipboard operation
CoGAPS copied to clipboard

102 patternmarkers all returning empty lists

Open dimalvovs opened this issue 1 year ago • 3 comments

  • add a test that fails on empty patterMarkers
  • make it pass by rewriting the method for threshold='all'

dimalvovs avatar May 02 '24 22:05 dimalvovs

@kwoyshner can you review please?

dimalvovs avatar May 02 '24 22:05 dimalvovs

I tried reinstalling from this branch and was able to get patternMarkers with 'all' now, thank you!

kwoyshner avatar May 03 '24 16:05 kwoyshner

@kwoyshner do you want to have a look at threshold = 'cut'? I've updated it too. This part of code is poorly documented so I was not sure what that mode should do but there was a dimension mismatch. simplicityGENES function needs to be inspected for functionality.

dimalvovs avatar May 05 '24 16:05 dimalvovs