eggroll icon indicating copy to clipboard operation
eggroll copied to clipboard

roll_pair.py 代码判断条件错误

Open zchunhai opened this issue 2 years ago • 0 comments

https://github.com/FederatedAI/eggroll/blob/da7969f5fa330489fc2a0da3aabacb70916d6987/python/eggroll/roll_pair/roll_pair.py#L64C1-L66C100

        self.in_memory_output = RollPairConfKeys.EGGROLL_ROLLPAIR_IN_MEMORY_OUTPUT.get_with(session.get_all_options())
        if not self.default_store_type:
            raise ValueError(f'in_memory_output "{self.in_memory_output}" not found for roll pair')

判断条件错了,应该改为:

        self.in_memory_output = RollPairConfKeys.EGGROLL_ROLLPAIR_IN_MEMORY_OUTPUT.get_with(session.get_all_options())
        if not self.in_memory_output:
            raise ValueError(f'in_memory_output "{self.in_memory_output}" not found for roll pair')

@forgivedengkai

zchunhai avatar Nov 15 '23 02:11 zchunhai