Frazer Smith

Results 179 comments of Frazer Smith

@oschwartz10612 looks like this can be closed as it was resolved. :)

> "Accept-Encoding" is always added to Vary for both compressable and non-compressable content-types. This should only be added if content-type is compressable. @rasander Do you have a link to a...

Closing as has been answered by @mcollina above.

I can't replicate using: - Typescript 5.4.5 - VS Code 1.88.1 - Fastify 4.26.2 - Fastify/cors 9.0.1 Screenshot from VS Code below shows no errors/warnings: ![image](https://github.com/fastify/fastify-cors/assets/43814140/889af799-5f9a-4b7f-9b15-a2155df2b676) Running `tsc` builds just...

@danjenkins @Rai-Sahil I'm -1 on this for the time being until all major browsers support this, not just Chromium. Thanks for raising it though! [Firefox's support for this is in...

> I would treats it the same as [fastify/fastify-cookie#261](https://github.com/fastify/fastify-cookie/pull/261) > > In order to get the PR accepted, > > * Mark the feature as experimental (meaning it would change...

This has been resolved partially by #27 and #30. @jstewmon would you be happy to rebase and review conflicts please?

@jmealo are you still wanting to push forward with this?