Fallenbagel
feat: Jellyfin/Emby server type setup
Description
This pull request introduces a new server setup for Jellyfin/Emby users. It now mandates the selection of a serverType during the setup process for jellyseerr. Consequently, the previous reliance on an environment variable to define the server type has been deprecated due to its unreliability and hacky nature. This update offers a more dependable and definitive approach to specifying the server type for jellyseerr setup.
Furthermore, there are breaking changes to the API. The media server setup for Jellyfin/Emby users now demands the selection of a serverType (Jellyfin or Emby) during setup, specifically at the endpoint /api/v1/auth/jellyfin
Screenshot (if UI-related)
Setup page during initial load:
Setup Page after selecting Jellyfin:
Setup Page after selecting Emby:
To-Dos
- [x] Successful build
yarn build - [ ] Translation keys
yarn i18n:extract - [ ] Database migration (if required)
Issues Fixed or Closed
- Fixes #XXXX
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you for this. How can I help you on this and test?
First we need to merge #773. Then this pr will require a refactor to support the new setting schema. Once that's done I'll release a preview tag to test this c:
But for now, you could help us test #773 ;)
(will create a preview tag tonight. Though make sure not to run it on prod, but we want test instances to be done with existing config so duplicate config and test as we want to see if our migration works)
I am using Docker, so what I could do is build the image with your preview tag, spin up a new docker container with a copy of my production config folder, and test that way.
I am using Docker, so what I could do is build the image with your preview tag, spin up a new docker container with a copy of my production config folder, and test that way.
The preview tag will already be built. You'll just have to pull it and try :)
Sounds good, even better. Let me know when that's ready. I assume it is, but do you have the docker tag?
Sounds good, even better. Let me know when that's ready. I assume it is, but do you have the docker tag?
https://github.com/Fallenbagel/jellyseerr/pull/773#issuecomment-2135013667
This sounds great and i'm looking forward to this. it would be enough to get me to switch off of ombi, but why not just go all the way and have support for Emby/Jellyfin/Plex all at once. That's my current setup & that would bring this in line with Ombi's level of support
This sounds great and i'm looking forward to this. it would be enough to get me to switch off of ombi, but why not just go all the way and have support for Emby/Jellyfin/Plex all at once. That's my current setup & that would bring this in line with Ombi's level of support
This is not yet possible due to the way overseerr/jellyseerr works. It requires decoupling of itself to not be dependent on media servers first (https://github.com/sct/overseerr/pull/3015)
You can follow the issue #100
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.
Let me know when ready to test pr image when available. Looks like it's fallenbagel/jellyseerr:preview-jellyfin-emby-server-type
Let me know when ready to test pr image when available. Looks like it's
fallenbagel/jellyseerr:preview-jellyfin-emby-server-type
I just published another preview, you can test it with the preview-jellyfin-emby-server-type tag
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.