git-recall icon indicating copy to clipboard operation
git-recall copied to clipboard

Doesn't work in rxvt; just reprints list of commits

Open yggdr opened this issue 9 years ago • 10 comments

In rxvt-unicode 9.22 on FreeBSD 11.0 (using zsh and /bin/sh) git recall prints the commits, but hitting j/k/Up/Down just prints out the same commits once more. No commit is marked like in the gif at any time. Tab has a similar effect of partial reprint of the lines.

yggdr avatar Jan 30 '17 08:01 yggdr

Works on Debian linux, rxvt-unicode 9.20 This seems to be the same bug as #6

henryk3dp avatar Jan 30 '17 09:01 henryk3dp

Same happens on OS X 10.11.6.

agarzola avatar Jan 30 '17 21:01 agarzola

Same on Ubuntu 16.04; However, if I maximize the terminal window, the problem will no longer exist.

mkermani144 avatar Jan 31 '17 05:01 mkermani144

Same as @mkermani144 an @agarzola and in addition, if I press tab key to expand the commit, just reprints again the next line.

mangelsnc avatar Feb 02 '17 08:02 mangelsnc

Hi, nice project! I have tested it in Git console for Windows (MinGW). I know the Readme says a Linux/OSX OS is required, but it seemed to me that it works just fine under MinGW except for this bug. I experience the same thing, every time I press Up/Down keys, the list of commits is reprinted leaving a duplicated first line behind.

desko27 avatar Feb 03 '17 17:02 desko27

At least on Mac 10.12.3 (and in my case) this is due to Apple's sed flavor behaving differently than GNU sed. If you download the GNU flavor and change the call to the executable, it works.

wagnerand avatar Feb 06 '17 14:02 wagnerand

This indeed fixes the main functionality (going through the list, opening them with tab), but not the reprinting and highlighting one.

yggdr avatar Feb 06 '17 17:02 yggdr

Problem resolved on OS X with bash 4.3 or more.

Fakerr avatar Jun 11 '17 20:06 Fakerr

Erm, no. Why would bash fix this?

In rxvt-unicode 9.22 on FreeBSD 11.0 (using zsh and /bin/sh) Current code from master (9c53028) is still nonfunctioning on FreeBSD 11.0 with urxvt and zsh.

yggdr avatar Jun 11 '17 20:06 yggdr

Well, upgrading to bash 4.4 in mac OS + some fixes I added resolved the issue, but I didn't try on FreeBSD to be honest. Did you try it with bash and it didn't work ? @yggdr

Fakerr avatar Jun 11 '17 21:06 Fakerr