Barotrauma icon indicating copy to clipboard operation
Barotrauma copied to clipboard

Fix multiple dedicated servers running on same IP Address not working properly

Open evilfactory opened this issue 3 years ago • 4 comments

This PR fixes two bugs:

  1. Multiple servers on same IP wouldn't show up on the server browser, this is fixed by adding the port value check that was left out here: https://github.com/Regalis11/Barotrauma/blob/master/Barotrauma/BarotraumaClient/ClientSource/Screens/ServerListScreen.cs#L1766-L1767

  2. Multiple servers on same IP would have "?" as ping, this is fixed by changing activePings so it uses a ServerInfo object instead of a string IP Address

Related to #6412

evilfactory avatar Jun 28 '22 18:06 evilfactory

Please add this soon. It would help a lot.

MassCraxx avatar Aug 06 '22 00:08 MassCraxx

@MassCraxx you can build the forked branch https://github.com/evilfactory/LuaCsForBarotrauma/tree/multiple-dedicated-servers-fix if you need this

Here's how: https://github.com/Regalis11/Barotrauma/blob/master/CONTRIBUTING.md#building-the-game

mygamingaccount avatar Aug 09 '22 14:08 mygamingaccount

@MassCraxx you can build the forked branch https://github.com/evilfactory/LuaCsForBarotrauma/tree/multiple-dedicated-servers-fix if you need this

Here's how: https://github.com/Regalis11/Barotrauma/blob/master/CONTRIBUTING.md#building-the-game

This won't work, every single player would need to use that custom build of the game, and that's not doable.

evilfactory avatar Aug 09 '22 15:08 evilfactory

I see the change is client side, never mind.

mygamingaccount avatar Aug 09 '22 17:08 mygamingaccount